Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2061)

Issue 802163002: include local functions in completion suggestions (Closed)

Created:
6 years ago by danrubel
Modified:
6 years ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

include local functions in completion suggestions BUG= R=paulberry@google.com Committed: https://code.google.com/p/dart/source/detail?r=42363

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -5 lines) Patch
M pkg/analysis_server/lib/src/services/completion/local_declaration_visitor.dart View 1 chunk +11 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/completion_test.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M pkg/analysis_server/test/services/completion/completion_test_util.dart View 3 chunks +79 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
danrubel
6 years ago (2014-12-14 17:19:47 UTC) #2
Paul Berry
lgtm
6 years ago (2014-12-15 16:36:21 UTC) #3
danrubel
6 years ago (2014-12-15 17:11:44 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 42363 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698