Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 80163002: Test for aliasing of typed data for setRange (Closed)

Created:
7 years, 1 month ago by sra1
Modified:
6 years, 10 months ago
CC:
reviews_dartlang.org, Cutch, floitsch
Visibility:
Public.

Description

Test for aliasing of typed data for setRange BUG= R=lrn@google.com Committed: https://code.google.com/p/dart/source/detail?r=30817

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -0 lines) Patch
M tests/lib/lib.status View 1 3 chunks +4 lines, -0 lines 0 comments Download
A tests/lib/typed_data/typed_data_setRange_test.dart View 1 1 chunk +101 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sra1
Please review this test in the light of Issue 15231. If we are agreed on ...
7 years, 1 month ago (2013-11-21 05:10:28 UTC) #1
Lasse Reichstein Nielsen
https://codereview.chromium.org/80163002/diff/1/tests/lib/typed_data/typed_data_setRange_test.dart File tests/lib/typed_data/typed_data_setRange_test.dart (right): https://codereview.chromium.org/80163002/diff/1/tests/lib/typed_data/typed_data_setRange_test.dart#newcode33 tests/lib/typed_data/typed_data_setRange_test.dart:33: Expect.equals('[1, 2, 3, 4, 5, 6, 7, 8]', '$a2'); ...
7 years, 1 month ago (2013-11-21 09:50:37 UTC) #2
Lasse Reichstein Nielsen
lgtm https://codereview.chromium.org/80163002/diff/1/tests/lib/typed_data/typed_data_setRange_test.dart File tests/lib/typed_data/typed_data_setRange_test.dart (right): https://codereview.chromium.org/80163002/diff/1/tests/lib/typed_data/typed_data_setRange_test.dart#newcode33 tests/lib/typed_data/typed_data_setRange_test.dart:33: Expect.equals('[1, 2, 3, 4, 5, 6, 7, 8]', ...
7 years ago (2013-11-25 07:16:48 UTC) #3
sra1
7 years ago (2013-12-03 17:50:41 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r30817 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698