Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 801543002: Rework instrumentation API (Closed)

Created:
6 years ago by Brian Wilkerson
Modified:
6 years ago
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Clean-up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -52 lines) Patch
M pkg/analysis_server/lib/driver.dart View 1 chunk +5 lines, -6 lines 0 comments Download
M pkg/analysis_server/lib/http_server.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/analysis_server.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M pkg/analysis_server/lib/src/channel/byte_stream_channel.dart View 5 chunks +7 lines, -6 lines 0 comments Download
M pkg/analysis_server/lib/src/channel/web_socket_channel.dart View 4 chunks +6 lines, -6 lines 0 comments Download
M pkg/analysis_server/lib/src/socket_server.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/stdio_server.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/analysis_abstract.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/analysis_server_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/channel/byte_stream_channel_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/channel/web_socket_channel_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/domain_analysis_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/domain_completion_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/domain_execution_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/domain_server_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/socket_server_test.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/instrumentation/instrumentation.dart View 1 2 chunks +74 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
danrubel
lgtm
6 years ago (2014-12-12 00:17:35 UTC) #4
scheglov
LGTM
6 years ago (2014-12-12 00:22:54 UTC) #5
Brian Wilkerson
6 years ago (2014-12-12 16:00:41 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as 42321 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698