Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 800913002: Report pub status (Closed)

Created:
6 years ago by Brian Wilkerson
Modified:
6 years ago
Reviewers:
scheglov, keertip
CC:
reviews_dartlang.org, Paul Berry, jwren
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+247 lines, -30 lines) Patch
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/AnalysisServerListener.java View 2 chunks +7 lines, -3 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/AnalysisServerListenerAdapter.java View 2 chunks +2 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/BroadcastAnalysisServerListener.java View 2 chunks +3 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/NotificationServerStatusProcessor.java View 2 chunks +24 lines, -3 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/MockAnalysisServerListener.java View 2 chunks +2 lines, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/TestAnalysisServerListener.java View 2 chunks +3 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/timing/AnalyzeEngineInServer.java View 2 chunks +2 lines, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/analysis/model/WorkspaceAnalysisServerListener.java View 1 4 chunks +35 lines, -12 lines 0 comments Download
M pkg/analysis_server/doc/api.html View 4 chunks +19 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/analysis_server.dart View 2 chunks +16 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/context_manager.dart View 2 chunks +16 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/generated_protocol.dart View 7 chunks +77 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/integration/integration_test_methods.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/integration/protocol_matchers.dart View 2 chunks +15 lines, -1 line 0 comments Download
M pkg/analysis_server/tool/spec/spec_input.html View 2 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Brian Wilkerson
6 years ago (2014-12-12 15:59:39 UTC) #2
scheglov
LGTM https://codereview.chromium.org/800913002/diff/1/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/analysis/model/WorkspaceAnalysisServerListener.java File editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/analysis/model/WorkspaceAnalysisServerListener.java (right): https://codereview.chromium.org/800913002/diff/1/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/analysis/model/WorkspaceAnalysisServerListener.java#newcode200 editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/analysis/model/WorkspaceAnalysisServerListener.java:200: private void waitUntilAnalysisComplete() { Should we rename this ...
6 years ago (2014-12-12 16:25:34 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/800913002/diff/1/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/analysis/model/WorkspaceAnalysisServerListener.java File editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/analysis/model/WorkspaceAnalysisServerListener.java (right): https://codereview.chromium.org/800913002/diff/1/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/analysis/model/WorkspaceAnalysisServerListener.java#newcode200 editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/analysis/model/WorkspaceAnalysisServerListener.java:200: private void waitUntilAnalysisComplete() { > Should we rename this ...
6 years ago (2014-12-12 16:57:00 UTC) #4
Brian Wilkerson
6 years ago (2014-12-12 17:40:28 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as 42328 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698