dart2js OldEmitter: name anonymous function so it does not need to be copied in deferred parts.

dart2js OldEmitter: name anonymous function so it does not need to be copied in deferred parts.

R=floitsch@google.com, sigurdm@google.com

Committed: https://code.google.com/p/dart/source/detail?r=42626

[zarah, 2015-01-05 13:36:50]

Patchset #1 (id:1) has been deleted

[zarah, 2015-01-05 13:39:17]

zarah@google.com changed reviewers:
+ floitsch@google.com, sigurdm@google.com

[floitsch, 2015-01-05 13:46:19]

LGTM.

https://codereview.chromium.org/800903005/diff/20001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart (right):

https://codereview.chromium.org/800903005/diff/20001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart:1507:
'$parseReflectionDataName$N');
indent that line.

https://codereview.chromium.org/800903005/diff/20001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart
(right):

https://codereview.chromium.org/800903005/diff/20001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart:422:
function parseReflectionData(reflectionData) {
Use the shared name.
I guess the dependency should be from the reflection_data_parser file to the
emitter.
So the name should be in this file and the emitter should reference the name
here.

[sigurdm, 2015-01-05 13:55:56]

Thanks! I should have done this long time ago.
LGTM.

[zarah, 2015-01-05 14:00:26]

https://codereview.chromium.org/800903005/diff/20001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart (right):

https://codereview.chromium.org/800903005/diff/20001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart:1507:
'$parseReflectionDataName$N');
On 2015/01/05 13:46:19, floitsch wrote:
> indent that line.

OK, then I'm also indenting the one two lines above.

https://codereview.chromium.org/800903005/diff/20001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart
(right):

https://codereview.chromium.org/800903005/diff/20001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart:422:
function parseReflectionData(reflectionData) {
On 2015/01/05 13:46:19, floitsch wrote:
> Use the shared name.
> I guess the dependency should be from the reflection_data_parser file to the
> emitter.
> So the name should be in this file and the emitter should reference the name
> here.

Done.

[floitsch, 2015-01-05 14:41:08]

https://codereview.chromium.org/800903005/diff/20001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart (right):

https://codereview.chromium.org/800903005/diff/20001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart:1507:
'$parseReflectionDataName$N');
On 2015/01/05 14:00:26, zarah wrote:
> On 2015/01/05 13:46:19, floitsch wrote:
> > indent that line.
> 
> OK, then I'm also indenting the one two lines above.

or even better:

mainBuffer.write(
    '${globalsHolder} ...'

Ideally it fits on one line then.

[zarah, 2015-01-06 11:45:07]

https://codereview.chromium.org/800903005/diff/20001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart (right):

https://codereview.chromium.org/800903005/diff/20001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart:1507:
'$parseReflectionDataName$N');
On 2015/01/05 14:41:07, floitsch wrote:
> On 2015/01/05 14:00:26, zarah wrote:
> > On 2015/01/05 13:46:19, floitsch wrote:
> > > indent that line.
> > 
> > OK, then I'm also indenting the one two lines above.
> 
> or even better:
> 
> mainBuffer.write(
>     '${globalsHolder} ...'
> 
> Ideally it fits on one line then.

Done.

[zarah, 2015-01-06 11:47:38]

Patchset #3 (id:60001) has been deleted

[zarah, 2015-01-06 11:48:18]

Patchset #3 (id:80001) has been deleted

[zarah, 2015-01-06 12:05:20]

Committed patchset #2 (id:40001) manually as 42626 (presubmit successful).