Issue 800733003: Generate sh-compatible binstubs on Unix.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 800733003: Generate sh-compatible binstubs on Unix. (Closed)

Created:
6 years ago by nweiz

Modified:
6 years ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Generate sh-compatible binstubs on Unix. Previously, binstubs used [[ ]], which is a bash-specific construct. R=rnystrom@google.com BUG=21854 Committed: https://code.google.com/p/dart/source/detail?r=42308

Patch Set 1 #

Total comments: 1

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	sdk/lib/_internal/pub/lib/src/global_packages.dart	View		1 chunk	+1 line, -1 line	1 comment	Download
	M	sdk/lib/_internal/pub_generated/lib/src/global_packages.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

nweiz

Committed patchset #1 (id:1) manually as 42308 (presubmit successful).

6 years ago (2014-12-12 01:52:15 UTC) #3

ahe

6 years ago (2014-12-12 09:04:42 UTC) #4

Message was sent while issue was closed.

FYI

https://codereview.chromium.org/800733003/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/global_packages.dart (right):

https://codereview.chromium.org/800733003/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/global_packages.dart:697: if [ \$exit_code != 255
]; then
If you want this to work in non-bash shells, then you should get in the habit of
quoting variables:

if [ "\$exit_code" != 255 ]; then

In this specific case it doesn't matter, but generally, older shells will behave
differently from bash if you don't quote variables. For example, if $exit_code
is empty or undefined, some shells will parse it as:

if [ != 255 ]; then

Which leads to an error.

Expand Messages | Collapse Messages