Nicer pretty printing of jsAst object literals.

Nicer pretty printing of jsAst object literals.

When printing an object literal it is often nice if each property is
on its own line. This CL adds an option allowing for this.
Also this is used for ObjectLiterals created by ClassBuilder.
BUG=
R=ahe@google.com

Committed: https://code.google.com/p/dart/source/detail?r=30504

Committed: https://code.google.com/p/dart/source/detail?r=30565

[ahe, 2013-11-21 08:30:04]

LGTM, thank you!

https://codereview.chromium.org/80053004/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/js/nodes.dart (right):

https://codereview.chromium.org/80053004/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/js/nodes.dart:931: * Constructs a new
object-initializer containing the given properties.
properties -> [properties].

[sigurdm, 2013-11-21 08:35:57]

Notice that this CL is expected to increase code-size of the non-minified js
because more indented lines are printed.

[sigurdm, 2013-11-21 10:22:19]

https://codereview.chromium.org/80053004/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/js/nodes.dart (right):

https://codereview.chromium.org/80053004/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/js/nodes.dart:931: * Constructs a new
object-initializer containing the given properties.
On 2013/11/21 08:30:05, ahe wrote:
> properties -> [properties].

Done.

[sigurdm, 2013-11-21 10:29:36]

Committed patchset #2 manually as r30504 (presubmit successful).

[sigurdm, 2013-11-21 11:20:34]

This seems to clash with several unittests.

For example
dart2js/no_constructor_body_test.dart

has the line:
    Expect.isTrue(generated.contains('A: {"": "Object;", static:'));

Is there a nice way to do this check that is less sensitive to whitespace?

[ahe, 2013-11-21 12:23:48]

On 2013/11/21 11:20:34, sigurdm wrote:
> This seems to clash with several unittests.
> 
> For example
> dart2js/no_constructor_body_test.dart
> 
> has the line:
>     Expect.isTrue(generated.contains('A: {"": "Object;", static:'));
> 
> Is there a nice way to do this check that is less sensitive to whitespace?

Use a regular expression:

Expect.isTrue(generated.contains(new RegExp('A: {[ \n]*"": "Object;"[
\n]*,static:')));

[ahe, 2013-11-21 15:00:27]

LGTM!

[sigurdm, 2013-11-22 08:06:31]

Committed patchset #3 manually as r30565 (presubmit successful).