Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 800453003: Revert "Revert "Revert "Disable the irregexp backend.""" (Closed)

Created:
6 years ago by zerny-google
Modified:
6 years ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Revert "Revert "Revert "Disable the irregexp backend.""" This enables the irregexp backend by reverting commit http://code.google.com/p/dart/source/detail?r=42246 R=fschneider@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=42312

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -18 lines) Patch
M runtime/lib/regexp.cc View 1 chunk +1 line, -1 line 0 comments Download
M tests/co19/co19-dart2dart.status View 2 chunks +0 lines, -9 lines 0 comments Download
M tests/co19/co19-runtime.status View 2 chunks +0 lines, -6 lines 0 comments Download
M tests/corelib/corelib.status View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
zerny-google
Local testing of dartium shows that the previous test failures were due to the merging ...
6 years ago (2014-12-11 15:13:22 UTC) #1
Florian Schneider
LGTM. Let's hope it sticks this time.
6 years ago (2014-12-11 15:30:05 UTC) #2
zerny-google
6 years ago (2014-12-12 09:02:32 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 42312 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698