Avoid repeating common parts of ProgramResults.

Avoid repeating common parts of ProgramResults.

R=johnniwinther@google.com

Committed: https://code.google.com/p/dart/source/detail?r=42387

[ahe, 2014-12-16 10:49:24]

Patchset #1 (id:1) has been deleted

[ahe, 2014-12-16 10:50:05]

ahe@google.com changed reviewers:
+ johnniwinther@google.com

[ahe, 2014-12-16 11:28:10]

Uploaded new patch set after diffing DOM before and after to ensure no
unintentional changes.

[Johnni Winther, 2014-12-16 11:39:07]

lgtm

https://codereview.chromium.org/799403005/diff/20001/dart/tests/try/web/incre...
File dart/tests/try/web/incremental_compilation_update_test.dart (right):

https://codereview.chromium.org/799403005/diff/20001/dart/tests/try/web/incre...
dart/tests/try/web/incremental_compilation_update_test.dart:49: const [
I would insert a constant class at this level:

class EncodedResult {
  final List updates;
  final List<ProgramExpectation> expectations;
 
  const EncodedResult(this.updates, this.expectations);
}

such that the test data would be

const List<EncodedResult> = const <EncodedResult>[
  const EncodedResult(
    const [
      ... updates ...
    ],
    const <ProgramExpectation>[
      ... expectations ...
    ]
  ),
  const EncodedResult(
    ...
  ),
  ...
];

[ahe, 2014-12-16 11:58:50]

PTAL

https://codereview.chromium.org/799403005/diff/20001/dart/tests/try/web/incre...
File dart/tests/try/web/incremental_compilation_update_test.dart (right):

https://codereview.chromium.org/799403005/diff/20001/dart/tests/try/web/incre...
dart/tests/try/web/incremental_compilation_update_test.dart:49: const [
On 2014/12/16 11:39:07, Johnni Winther wrote:
> I would insert a constant class at this level:
> 
> class EncodedResult {
>   final List updates;
>   final List<ProgramExpectation> expectations;
>  
>   const EncodedResult(this.updates, this.expectations);
> }
> 
> such that the test data would be
> 
> const List<EncodedResult> = const <EncodedResult>[
>   const EncodedResult(
>     const [
>       ... updates ...
>     ],
>     const <ProgramExpectation>[
>       ... expectations ...
>     ]
>   ),
>   const EncodedResult(
>     ...
>   ),
>   ...
> ];

Done.

[Johnni Winther, 2014-12-16 12:53:04]

lgtm

[ahe, 2014-12-16 13:05:12]

Committed patchset #4 (id:80001) manually as 42387 (presubmit successful).