Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 799063002: Avoid NPE in package resolver if there's a problem running 'pub list' (Closed)

Created:
6 years ago by Brian Wilkerson
Modified:
6 years ago
Reviewers:
Paul Berry, jwren
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Avoid NPE in package resolver if there's a problem running 'pub list' R=paulberry@google.com Committed: https://code.google.com/p/dart/source/detail?r=42347

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M pkg/analyzer/lib/src/analyzer_impl.dart View 2 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Brian Wilkerson
6 years ago (2014-12-12 21:31:54 UTC) #2
jwren
On 2014/12/12 21:31:54, Brian Wilkerson wrote: LGTM
6 years ago (2014-12-12 21:33:55 UTC) #3
Paul Berry
Can we have a slightly more descriptive commit message? E.g. something like "avoid null reference ...
6 years ago (2014-12-12 21:37:29 UTC) #4
Brian Wilkerson
6 years ago (2014-12-12 21:52:35 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 42347 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698