Issue 798933002: When canonicalizing UnboxInt32([tr], BoxInt64()) make sure to mark resulting converter truncating.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 798933002: When canonicalizing UnboxInt32([tr], BoxInt64()) make sure to mark resulting converter truncating. (Closed)

Created:
6 years ago by Vyacheslav Egorov (Google)

Modified:
6 years ago

Reviewers:
Florian Schneider, fscheider

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

When canonicalizing UnboxInt32([tr], BoxInt64()) make sure to mark resulting converter truncating. We regressed this logic in r41736 when we started to checking whether current UnboxInt32 can deoptimize, instead of whether it is truncating or not. This was too aggressive. Additionally fix CanDeoptimize for UnboxInt32([tr], BoxInt64()). It was always returning true because CompileType is not smart enough to encode that Boxing returns either Smi or Mint, which is enough to guarantee that truncating UnboxInt32 won't deoptimize. R=fschneider@google.com, fscheider@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=42319

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	runtime/vm/intermediate_language.cc	View		2 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Vyacheslav Egorov (Google)

6 years ago (2014-12-12 13:54:28 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 42319 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages