Issue 798873007: Temporarily move vm_tag_ from BaseIsolate to Isolate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 798873007: Temporarily move vm_tag_ from BaseIsolate to Isolate. (Closed)

Created:
5 years, 11 months ago by koda

Modified:
5 years, 11 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Temporarily move vm_tag_ from BaseIsolate to Isolate. This field is used by performance sensitive generated code. Moving it out of BaseIsolate will simplify the first step towards replacing BaseIsolate with an actual thread state abstraction. It will later be migrated to that thread class (along with many other fields of Isolate). Also remove an unused accessor from Isolate. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=42884

Patch Set 1 #

Patch Set 2 : #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -17 lines)			Patch
M	runtime/vm/base_isolate.h	View		3 chunks	+1 line, -11 lines	0 comments	Download
M	runtime/vm/isolate.h	View	1	3 chunks	+7 lines, -4 lines	0 comments	Download
M	runtime/vm/isolate.cc	View		2 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

koda

5 years, 11 months ago (2015-01-14 21:18:53 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as r42884 (presubmit successful).

Expand Messages | Collapse Messages