dart2js: change output so that in stack traces, dart method names get prefixed with 'dart.' instead…

dart2js: Change output so that in stack traces, dart method names get prefixed with 'dart.' instead of 'parseReflectionData'.

BUG=dartbug.com/22000
R=ahe@google.com, floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=42661

[zarah, 2015-01-07 12:07:00]

Patchset #1 (id:1) has been deleted

[zarah, 2015-01-07 12:09:17]

zarah@google.com changed reviewers:
+ floitsch@google.com

[ahe, 2015-01-07 12:20:16]

ahe@google.com changed reviewers:
+ ahe@google.com

[ahe, 2015-01-07 12:20:16]

lgtm

Guess I'm finding issues in my own comments :-)

https://codereview.chromium.org/798873004/diff/20001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart (right):

https://codereview.chromium.org/798873004/diff/20001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart:1418: // [map] returns
an object literal that V8 shouldn not try to optimize with a
shouldn't (remove "not").

map doesn't return an "object literal", just an "object".

https://codereview.chromium.org/798873004/diff/20001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart:1423: function
map(x){x=Object.create(null);x.x=0;delete x.x;return x}
Now that this is parsed, I suggest you reformat it: one statement per line.

[floitsch, 2015-01-07 13:07:39]

LGTM.

https://codereview.chromium.org/798873004/diff/30001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart (right):

https://codereview.chromium.org/798873004/diff/30001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart:1491:
mainBuffer..write('var dart = [$n')
Add a comment why you assign to a temporary first.

https://codereview.chromium.org/798873004/diff/30001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart:1939: ..write('var dart
= [$n ')
ditto.

[zarah, 2015-01-07 13:45:17]

https://codereview.chromium.org/798873004/diff/20001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart (right):

https://codereview.chromium.org/798873004/diff/20001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart:1418: // [map] returns
an object literal that V8 shouldn not try to optimize with a
On 2015/01/07 12:20:16, ahe wrote:
> shouldn't (remove "not").
> 
> map doesn't return an "object literal", just an "object".

Done.

https://codereview.chromium.org/798873004/diff/20001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart:1423: function
map(x){x=Object.create(null);x.x=0;delete x.x;return x}
On 2015/01/07 12:20:16, ahe wrote:
> Now that this is parsed, I suggest you reformat it: one statement per line.

Done.

https://codereview.chromium.org/798873004/diff/30001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart (right):

https://codereview.chromium.org/798873004/diff/30001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart:1491:
mainBuffer..write('var dart = [$n')
On 2015/01/07 13:07:39, floitsch wrote:
> Add a comment why you assign to a temporary first.

Done.

https://codereview.chromium.org/798873004/diff/30001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart:1939: ..write('var dart
= [$n ')
On 2015/01/07 13:07:39, floitsch wrote:
> ditto.

Done.

[zarah, 2015-01-07 14:19:01]

Committed patchset #3 (id:50001) manually as 42661 (presubmit successful).

[ahe, 2015-01-07 14:19:11]

lgtm

https://codereview.chromium.org/798873004/diff/50001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart (right):

https://codereview.chromium.org/798873004/diff/50001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart:1493: // traces and
profile entries.
(on V8).

https://codereview.chromium.org/798873004/diff/50001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart:1944: // in stack
traces and profile entries.
Refactor code so you don't need to duplicate the comment.