Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 798583004: Refactor to use streams for reusability. (Closed)

Created:
5 years, 11 months ago by ahe
Modified:
5 years, 11 months ago
Reviewers:
kasperl
CC:
reviews_dartlang.org, Johnni Winther, lukechurch
Target Ref:
refs/remotes/trunk
Visibility:
Public.

Description

Refactor to use streams for reusability. R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=43009

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix typo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -17 lines) Patch
M dart/pkg/dart2js_incremental/lib/compiler.dart View 1 5 chunks +92 lines, -17 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
ahe
5 years, 11 months ago (2015-01-20 12:09:55 UTC) #2
kasperl
LGTM. I like it. https://codereview.chromium.org/798583004/diff/1/dart/pkg/dart2js_incremental/lib/compiler.dart File dart/pkg/dart2js_incremental/lib/compiler.dart (right): https://codereview.chromium.org/798583004/diff/1/dart/pkg/dart2js_incremental/lib/compiler.dart#newcode25 dart/pkg/dart2js_incremental/lib/compiler.dart:25: StreamSubscription<CompilerEvent> subscritpion = subscription
5 years, 11 months ago (2015-01-20 13:58:31 UTC) #3
ahe
Thank you, Kasper! https://codereview.chromium.org/798583004/diff/1/dart/pkg/dart2js_incremental/lib/compiler.dart File dart/pkg/dart2js_incremental/lib/compiler.dart (right): https://codereview.chromium.org/798583004/diff/1/dart/pkg/dart2js_incremental/lib/compiler.dart#newcode25 dart/pkg/dart2js_incremental/lib/compiler.dart:25: StreamSubscription<CompilerEvent> subscritpion = On 2015/01/20 13:58:31, ...
5 years, 11 months ago (2015-01-20 14:04:33 UTC) #4
ahe
5 years, 11 months ago (2015-01-20 14:29:25 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as 43009 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698