Issue 798083002: Turn on incremental resolution.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 798083002: Turn on incremental resolution. (Closed)

Created:
6 years ago by scheglov

Modified:
6 years ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Turn on incremental resolution. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=42351

Patch Set 1 #

Total comments: 1

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -23 lines)			Patch
M	editor/tools/plugins/com.google.dart.tools.core/.options	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/DartCore.java	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/DartCoreDebug.java	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	pkg/analysis_server/lib/driver.dart	View	3 chunks	+0 lines, -13 lines	0 comments	Download
M	pkg/analysis_server/lib/src/analysis_server.dart	View	2 chunks	+1 line, -3 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/798083002/diff/1/pkg/analysis_server/lib/src/analysis_server.dart File pkg/analysis_server/lib/src/analysis_server.dart (right): https://codereview.chromium.org/798083002/diff/1/pkg/analysis_server/lib/src/analysis_server.dart#newcode199 pkg/analysis_server/lib/src/analysis_server.dart:199: contextDirectoryManager.defaultOptions.incremental = true; I assume we'll remove this ...

6 years ago (2014-12-12 20:56:50 UTC) #2

scheglov

6 years ago (2014-12-12 23:02:29 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 42351 (presubmit successful).

Expand Messages | Collapse Messages