Emit either csp or non-csp versions of the program.

Emit either csp or non-csp versions of the program.

R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=42451

[zarah, 2014-12-17 11:17:23]

zarah@google.com changed reviewers:
+ floitsch@google.com

[floitsch, 2014-12-17 15:03:38]

LGTM with comments.

https://codereview.chromium.org/797513004/diff/1/pkg/compiler/lib/src/js_emit...
File pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart (right):

https://codereview.chromium.org/797513004/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart:497:
${useCspOrNonCspVersion('''
There is an easier nicer solution:

`if (#) { ... }`

The template instantiation recognizes this case and removes the 'if' when the
hole is a boolean.

if (#inCspMode) { ... }
if (#notInCspMode) { ... }

(unless the template instantiator can deal with if/else.)

https://codereview.chromium.org/797513004/diff/1/pkg/compiler/lib/src/js_emit...
File pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart
(right):

https://codereview.chromium.org/797513004/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart:384: 
No need to build both variants.

jsAst.Statement tearOffGetter;
if (!compiler.useContentSecurityPolicy) {
  tearOffGetter = js.uncachedStatementTemplate('''...''');
} else {
  tearOffGetter = js.statement('''....''');
}

[zarah, 2014-12-18 08:22:16]

https://codereview.chromium.org/797513004/diff/1/pkg/compiler/lib/src/js_emit...
File pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart (right):

https://codereview.chromium.org/797513004/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart:497:
${useCspOrNonCspVersion('''
On 2014/12/17 15:03:38, floitsch wrote:
> There is an easier nicer solution:
> 
> `if (#) { ... }`
> 
> The template instantiation recognizes this case and removes the 'if' when the
> hole is a boolean.
> 
> if (#inCspMode) { ... }
> if (#notInCspMode) { ... }
> 
> (unless the template instantiator can deal with if/else.)

Done.

https://codereview.chromium.org/797513004/diff/1/pkg/compiler/lib/src/js_emit...
File pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart
(right):

https://codereview.chromium.org/797513004/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart:384: 
On 2014/12/17 15:03:38, floitsch wrote:
> No need to build both variants.
> 
> jsAst.Statement tearOffGetter;
> if (!compiler.useContentSecurityPolicy) {
>   tearOffGetter = js.uncachedStatementTemplate('''...''');
> } else {
>   tearOffGetter = js.statement('''....''');
> }

Done.

[zarah, 2014-12-18 08:25:14]

Patchset #2 (id:20001) has been deleted

[zarah, 2014-12-18 09:22:19]

Committed patchset #2 (id:40001) manually as 42451 (presubmit successful).