Instrument top-level exceptions

Instrument top-level exceptions

R=paulberry@google.com

Committed: https://code.google.com/p/dart/source/detail?r=42513

[Brian Wilkerson, 2014-12-19 17:04:25]

brianwilkerson@google.com changed reviewers:
+ paulberry@google.com

[Paul Berry, 2014-12-19 17:07:51]

lgtm

https://codereview.chromium.org/797503004/diff/1/pkg/analyzer/lib/instrumenta...
File pkg/analyzer/lib/instrumentation/instrumentation.dart (right):

https://codereview.chromium.org/797503004/diff/1/pkg/analyzer/lib/instrumenta...
pkg/analyzer/lib/instrumentation/instrumentation.dart:79:
'$_timestamp:$TAG_EXCEPTION:$message:$trace');
Should "$message" be escaped in any way to make it more machine readable in case
it contains a colon?

[Brian Wilkerson, 2014-12-19 17:10:47]

https://codereview.chromium.org/797503004/diff/1/pkg/analyzer/lib/instrumenta...
File pkg/analyzer/lib/instrumentation/instrumentation.dart (right):

https://codereview.chromium.org/797503004/diff/1/pkg/analyzer/lib/instrumenta...
pkg/analyzer/lib/instrumentation/instrumentation.dart:79:
'$_timestamp:$TAG_EXCEPTION:$message:$trace');
Good question. I thought about other special characters, but not colons. I'll
find out and fix it in a separate CL if necessary.

[Brian Wilkerson, 2014-12-19 17:11:10]

Committed patchset #1 (id:1) manually as 42513 (presubmit successful).