Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Issue 797343002: Deoptimize the world when single stepping. (Closed)

Created:
6 years ago by turnidge
Modified:
6 years ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Deoptimize the world when single stepping. It is possible that we may be stepping into an optimized frame otherwise. In fact, the current frame may be optimized if the isolate was interrupted instead of hitting a breakpoint. BUG= R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=42348

Patch Set 1 #

Patch Set 2 : code review #

Patch Set 3 : code review 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M runtime/vm/debugger.cc View 1 2 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
turnidge
6 years ago (2014-12-12 21:29:48 UTC) #2
hausner
lgtm
6 years ago (2014-12-12 22:00:45 UTC) #3
turnidge
6 years ago (2014-12-12 22:21:32 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 42348 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698