Issue 797103002: Don't include extra whitespace in YAML scalar spans.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 797103002: Don't include extra whitespace in YAML scalar spans. (Closed)

Created:
6 years ago by nweiz

Modified:
6 years ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Don't include extra whitespace in YAML scalar spans. R=rnystrom@google.com BUG=21841 Committed: https://code.google.com/p/dart/source/detail?r=42307

Patch Set 1 #

Total comments: 1

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -4 lines)			Patch
M	pkg/yaml/CHANGELOG.md	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	pkg/yaml/lib/src/scanner.dart	View	7 chunks	+7 lines, -2 lines	1 comment	Download
M	pkg/yaml/pubspec.yaml	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

lgtm https://codereview.chromium.org/797103002/diff/1/pkg/yaml/lib/src/scanner.dart File pkg/yaml/lib/src/scanner.dart (right): https://codereview.chromium.org/797103002/diff/1/pkg/yaml/lib/src/scanner.dart#newcode1087 pkg/yaml/lib/src/scanner.dart:1087: print("scanning block scalar"); Delete.

6 years ago (2014-12-12 01:47:37 UTC) #2

nweiz

6 years ago (2014-12-12 01:50:54 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 42307 (presubmit successful).

Expand Messages | Collapse Messages