Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1425)

Issue 796693004: Mark dart2js http_test as slow in checked mode. Also slow regexp test. (Closed)

Created:
5 years, 11 months ago by Bill Hesse
Modified:
5 years, 11 months ago
Reviewers:
floitsch, zerny-google
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Mark dart2js http_test as slow in checked mode. BUG= R=zerny@google.com Committed: https://code.google.com/p/dart/source/detail?r=42652

Patch Set 1 #

Patch Set 2 : Add slow regexp test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M tests/compiler/dart2js/dart2js.status View 1 chunk +1 line, -0 lines 0 comments Download
M tests/corelib/corelib.status View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Bill Hesse
This test has been on the border of timing out, at 55 seconds, since at ...
5 years, 11 months ago (2015-01-07 09:09:00 UTC) #2
Bill Hesse
5 years, 11 months ago (2015-01-07 09:19:10 UTC) #4
zerny-google
lgtm
5 years, 11 months ago (2015-01-07 09:21:45 UTC) #5
Bill Hesse
Committed patchset #2 (id:20001) manually as 42652 (presubmit successful).
5 years, 11 months ago (2015-01-07 10:04:02 UTC) #6
floitsch
5 years, 11 months ago (2015-01-07 11:36:40 UTC) #7
Message was sent while issue was closed.
LGTM.

Powered by Google App Engine
This is Rietveld 408576698