Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 796593004: Add an ArgResults.original getter. (Closed)

Created:
6 years ago by nweiz
Modified:
6 years ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -6 lines) Patch
M pkg/args/CHANGELOG.md View 1 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/args/lib/src/arg_results.dart View 1 2 chunks +9 lines, -4 lines 0 comments Download
M pkg/args/lib/src/parser.dart View 1 2 chunks +3 lines, -1 line 0 comments Download
M pkg/args/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M pkg/args/test/args_test.dart View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
nweiz
6 years ago (2014-12-11 00:25:02 UTC) #1
Bob Nystrom
https://codereview.chromium.org/796593004/diff/1/pkg/args/lib/src/arg_results.dart File pkg/args/lib/src/arg_results.dart (right): https://codereview.chromium.org/796593004/diff/1/pkg/args/lib/src/arg_results.dart#newcode51 pkg/args/lib/src/arg_results.dart:51: final List<String> original; What do you think of "arguments" ...
6 years ago (2014-12-11 01:13:23 UTC) #2
nweiz
Code review changes
6 years ago (2014-12-11 01:17:07 UTC) #3
nweiz
https://codereview.chromium.org/796593004/diff/1/pkg/args/lib/src/arg_results.dart File pkg/args/lib/src/arg_results.dart (right): https://codereview.chromium.org/796593004/diff/1/pkg/args/lib/src/arg_results.dart#newcode51 pkg/args/lib/src/arg_results.dart:51: final List<String> original; On 2014/12/11 01:13:23, Bob Nystrom wrote: ...
6 years ago (2014-12-11 01:17:18 UTC) #4
Bob Nystrom
LGTM!
6 years ago (2014-12-11 17:53:29 UTC) #5
Bob Nystrom
6 years ago (2014-12-11 17:53:48 UTC) #6
On 2014/12/11 17:53:29, Bob Nystrom wrote:
> LGTM!

Oh, and don't forget to publish this after it lands.

- bob

Powered by Google App Engine
This is Rietveld 408576698