Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1034)

Issue 796463003: Incremental compilation: correctly track emitted constants. (Closed)

Created:
6 years ago by ahe
Modified:
6 years ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, kasperl, lukechurch
Target Ref:
refs/remotes/trunk
Visibility:
Public.

Description

Incremental compilation: correctly track emitted constants. R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=42314

Patch Set 1 #

Patch Set 2 : Constant output list may be null. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -16 lines) Patch
M dart/pkg/dart2js_incremental/lib/library_updater.dart View 1 2 chunks +33 lines, -12 lines 0 comments Download
M dart/tests/try/web/incremental_compilation_update_test.dart View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
ahe
6 years ago (2014-12-12 08:13:02 UTC) #2
Johnni Winther
lgtm
6 years ago (2014-12-12 09:54:13 UTC) #3
ahe
PTAL (submitting patch set 2 TBR).
6 years ago (2014-12-12 11:46:38 UTC) #4
ahe
Committed patchset #2 (id:20001) manually as 42314 (presubmit successful).
6 years ago (2014-12-12 11:46:58 UTC) #5
Johnni Winther
6 years ago (2014-12-12 12:57:46 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698