Issue 795933005: Create a Tree IR builder for JavaScript specific nodes.

Issue 795933005: Create a Tree IR builder for JavaScript specific nodes. (Closed)

Created:
6 years ago by karlklose

Modified:
6 years ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Create a Tree IR builder for JavaScript specific nodes. R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=42429

Patch Set 2 : Move identicalFunction. #

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+82 lines, -41 lines)			Patch
M	pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart	View		2 chunks	+8 lines, -2 lines	0 comments	Download
M	pkg/compiler/lib/src/dart_backend/backend.dart	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
A	pkg/compiler/lib/src/js_backend/codegen/js_tree_builder.dart	View	1	1 chunk	+51 lines, -0 lines	0 comments	Download
M	pkg/compiler/lib/src/js_backend/codegen/task.dart	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart	View	1	7 chunks	+18 lines, -34 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Johnni Winther

lgtm https://codereview.chromium.org/795933005/diff/1/pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart File pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart (right): https://codereview.chromium.org/795933005/diff/1/pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart#newcode48 pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart:48: final Element identicalFunction; Remove [identicalFunction]. It is only ...

6 years ago (2014-12-17 13:43:52 UTC) #2

karlklose

https://codereview.chromium.org/795933005/diff/1/pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart File pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart (right): https://codereview.chromium.org/795933005/diff/1/pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart#newcode48 pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart:48: final Element identicalFunction; On 2014/12/17 13:43:52, Johnni Winther wrote: ...

6 years ago (2014-12-17 14:11:35 UTC) #4

karlklose

6 years ago (2014-12-17 14:15:12 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 42429 (presubmit successful).

Expand Messages | Collapse Messages