Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 795633004: filter imported element suggestions to reduce number of results sent to client (Closed)

Created:
6 years ago by danrubel
Modified:
6 years ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Visibility:
Public.

Description

filter imported element suggestions to reduce number of results sent to client BUG= R=paulberry@google.com Committed: https://code.google.com/p/dart/source/detail?r=42289

Patch Set 1 #

Patch Set 2 : merge #

Patch Set 3 : merge and fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -20 lines) Patch
M pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart View 1 chunk +8 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/imported_computer.dart View 1 chunk +31 lines, -5 lines 0 comments Download
M pkg/analysis_server/test/domain_completion_test.dart View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/test/services/completion/completion_test_util.dart View 9 chunks +130 lines, -14 lines 0 comments Download
M pkg/analysis_server/test/services/completion/imported_computer_test.dart View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
danrubel
6 years ago (2014-12-11 03:23:39 UTC) #2
Paul Berry
lgtm
6 years ago (2014-12-11 15:54:48 UTC) #3
danrubel
6 years ago (2014-12-11 17:18:18 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 42289 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698