Chromium Code Reviews

Issue 795343003: Add an additional optional argument to SpanScanner.spanFrom. (Closed)

Created:
6 years ago by nweiz
Modified:
6 years ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add an additional optional argument to SpanScanner.spanFrom. R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=42305

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+9 lines, -3 lines)
M pkg/string_scanner/CHANGELOG.md View 1 chunk +4 lines, -0 lines 0 comments
M pkg/string_scanner/lib/src/span_scanner.dart View 1 chunk +4 lines, -2 lines 0 comments
M pkg/string_scanner/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments

Messages

Total messages: 3 (0 generated)
nweiz
6 years ago (2014-12-11 23:55:49 UTC) #1
Bob Nystrom
LGTM! Don't forget to publish. :)
6 years ago (2014-12-12 01:34:10 UTC) #2
nweiz
6 years ago (2014-12-12 01:39:30 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 42305 (presubmit successful).

Powered by Google App Engine