Fix a couple type bugs in dart html and what seems like strange type choices in dart:core

Fix a couple type bugs in dart html and what seems like strange type choices in dart:core

BUG=
R=vsm@google.com

Committed: https://code.google.com/p/dart/source/detail?r=42550

[Jacob, 2014-12-11 01:00:42]

jacobr@google.com changed reviewers:
+ leafp@google.com, vsm@google.com

[Jacob, 2014-12-11 01:00:43]

Let me know if these fixes seem reasonable and I'll send the dart:core portion
of the CL over to the dart core team.

I think this makes the types specified more consistent.

[vsm, 2014-12-11 01:16:23]

lgtm for the non-iterable parts.

https://codereview.chromium.org/794953002/diff/1/sdk/lib/collection/iterable....
File sdk/lib/collection/iterable.dart (right):

https://codereview.chromium.org/794953002/diff/1/sdk/lib/collection/iterable....
sdk/lib/collection/iterable.dart:150: E firstWhere(bool test(E value), { E
orElse() }) {
Hmm, I guess the intent here is that orElse may return a non-E error value?

https://codereview.chromium.org/794953002/diff/1/sdk/lib/html/html_common/css...
File sdk/lib/html/html_common/css_class_set.dart (right):

https://codereview.chromium.org/794953002/diff/1/sdk/lib/html/html_common/css...
sdk/lib/html/html_common/css_class_set.dart:87: String lookup(Object value) =>
contains(value) ? value : null;
I'm surprised this and the above are typed to take Object instead of E (for
Set<E>), but your change seems consistent with the API:

https://api.dartlang.org/apidocs/channels/stable/dartdoc-viewer/dart:core.Set...

https://codereview.chromium.org/794953002/diff/1/sdk/lib/html/html_common/css...
sdk/lib/html/html_common/css_class_set.dart:187: String firstWhere(bool
test(String value), { String orElse() }) =>
orElse is typed Object in the docs:  

https://api.dartlang.org/apidocs/channels/stable/dartdoc-viewer/dart:core.Set...

https://codereview.chromium.org/794953002/diff/1/sdk/lib/html/html_common/css...
sdk/lib/html/html_common/css_class_set.dart:189: String lastWhere(bool
test(String value), { String orElse()}) =>
ditto

[kevmoo, 2014-12-11 01:23:54]

kevmoo@google.com changed reviewers:
+ kevmoo@google.com

[kevmoo, 2014-12-11 01:23:55]

DBC

https://codereview.chromium.org/794953002/diff/1/sdk/lib/collection/iterable....
File sdk/lib/collection/iterable.dart (right):

https://codereview.chromium.org/794953002/diff/1/sdk/lib/collection/iterable....
sdk/lib/collection/iterable.dart:150: E firstWhere(bool test(E value), { E
orElse() }) {
On 2014/12/11 01:16:22, vsm wrote:
> Hmm, I guess the intent here is that orElse may return a non-E error value?

But this is not the signature of the same methods in dart:core Iterable.

I'm guessing this is an oversight

https://codereview.chromium.org/794953002/diff/1/sdk/lib/html/html_common/css...
File sdk/lib/html/html_common/css_class_set.dart (right):

https://codereview.chromium.org/794953002/diff/1/sdk/lib/html/html_common/css...
sdk/lib/html/html_common/css_class_set.dart:187: String firstWhere(bool
test(String value), { String orElse() }) =>
On 2014/12/11 01:16:22, vsm wrote:
> orElse is typed Object in the docs:  
> 
>
https://api.dartlang.org/apidocs/channels/stable/dartdoc-viewer/dart:core.Set...

Be careful! Known issue in docs generator.

The source:
https://github.com/dart-lang/bleeding_edge/blob/master/dart/sdk/lib/core/iter...

https://codereview.chromium.org/794953002/diff/1/sdk/lib/html/html_common/css...
sdk/lib/html/html_common/css_class_set.dart:189: String lastWhere(bool
test(String value), { String orElse()}) =>
On 2014/12/11 01:16:22, vsm wrote:
> ditto

see above

[Jacob, 2014-12-11 17:32:23]

https://codereview.chromium.org/794953002/diff/1/sdk/lib/collection/iterable....
File sdk/lib/collection/iterable.dart (right):

https://codereview.chromium.org/794953002/diff/1/sdk/lib/collection/iterable....
sdk/lib/collection/iterable.dart:150: E firstWhere(bool test(E value), { E
orElse() }) {
On 2014/12/11 01:23:54, kevmoo wrote:
> On 2014/12/11 01:16:22, vsm wrote:
> > Hmm, I guess the intent here is that orElse may return a non-E error value?
> 
> But this is not the signature of the same methods in dart:core Iterable.
> 
> I'm guessing this is an oversight

Agreed. As far as I can tell this is just an oversight.

https://codereview.chromium.org/794953002/diff/1/sdk/lib/html/html_common/css...
File sdk/lib/html/html_common/css_class_set.dart (right):

https://codereview.chromium.org/794953002/diff/1/sdk/lib/html/html_common/css...
sdk/lib/html/html_common/css_class_set.dart:87: String lookup(Object value) =>
contains(value) ? value : null;
On 2014/12/11 01:16:22, vsm wrote:
> I'm surprised this and the above are typed to take Object instead of E (for
> Set<E>), but your change seems consistent with the API:
> 
>
https://api.dartlang.org/apidocs/channels/stable/dartdoc-viewer/dart:core.Set...

Plausible justification for the design: no need to add an extra "as" check when
looking up an object in a set. If the type happens to be wrong, the lookup will
return null not throw an exception.

https://codereview.chromium.org/794953002/diff/1/sdk/lib/html/html_common/css...
sdk/lib/html/html_common/css_class_set.dart:187: String firstWhere(bool
test(String value), { String orElse() }) =>
On 2014/12/11 01:23:55, kevmoo wrote:
> On 2014/12/11 01:16:22, vsm wrote:
> > orElse is typed Object in the docs:  
> > 
> >
>
https://api.dartlang.org/apidocs/channels/stable/dartdoc-viewer/dart:core.Set...
> 
> Be careful! Known issue in docs generator.
> 
> The source:
>
https://github.com/dart-lang/bleeding_edge/blob/master/dart/sdk/lib/core/iter...

The docs are misleading for this case as kevin said. Is there a bug I can star
on this issue?

[Jacob, 2014-12-12 02:01:09]

Moved the IterableMixin case over to 
https://codereview.chromium.org/791453005/

[kevmoo, 2014-12-12 02:54:42]

> The docs are misleading for this case as kevin said. Is there a bug I can star
> on this issue?

I don't think there is a bug for this specifically.

Please open one. PKG=docgen

[Jacob, 2014-12-12 16:39:12]

On 2014/12/12 02:54:42, kevmoo wrote:
> > The docs are misleading for this case as kevin said. Is there a bug I can
star
> > on this issue?
> 
> I don't think there is a bug for this specifically.
> 
> Please open one. PKG=docgen

Actually it isn't really a docgen bug. The signature for the method within the
Iterable class is fine.
https://api.dartlang.org/apidocs/channels/stable/dartdoc-viewer/dart:core.Ite...

The issue is that IterableBase has the wrong type.

[Jacob, 2014-12-22 18:48:56]

cc: floitschV8
Merged committing this CL along with the rollback CL of just the iterator change
that he approved already. Marked the failing co19 test as triggering a runtime
error in checked mode and filed a co19 bug.

[Jacob, 2014-12-22 18:49:17]

Committed patchset #4 (id:60001) manually as 42550 (presubmit successful).