Issue 794613002: Improve bitwise OR, AND ranges by using the same approximation we use for XOR.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 794613002: Improve bitwise OR, AND ranges by using the same approximation we use for XOR. (Closed)

Created:
6 years ago by Vyacheslav Egorov (Google)

Modified:
6 years ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Improve bitwise OR, AND ranges by using the same approximation we use for XOR. BUG= R=fschneider@google.com Committed: https://code.google.com/p/dart/source/detail?r=42258

Patch Set 1 #

Total comments: 1

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -4 lines)			Patch
	M	runtime/vm/flow_graph_range_analysis.cc	View		2 chunks	+3 lines, -4 lines	1 comment	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Florian Schneider

lgtm https://codereview.chromium.org/794613002/diff/1/runtime/vm/flow_graph_range_analysis.cc File runtime/vm/flow_graph_range_analysis.cc (right): https://codereview.chromium.org/794613002/diff/1/runtime/vm/flow_graph_range_analysis.cc#newcode2426 runtime/vm/flow_graph_range_analysis.cc:2426: Xor(left_range, right_range, result_min, result_max); Maybe this should be ...

6 years ago (2014-12-10 15:55:14 UTC) #3

Vyacheslav Egorov (Google)

6 years ago (2014-12-10 18:36:43 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 42258 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages