Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 794593002: Allow dart2js to compile calls to type literals when prefixed. (Closed)

Created:
6 years ago by sigurdm
Modified:
6 years ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, floitsch
Visibility:
Public.

Description

Allow dart2js to compile calls to type literals when prefixed. R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=42286

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M pkg/compiler/lib/src/resolution/members.dart View 1 1 chunk +6 lines, -0 lines 0 comments Download
A + tests/language/type_literal_prefix_call_test.dart View 1 chunk +3 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
sigurdm
6 years ago (2014-12-10 14:12:17 UTC) #2
Johnni Winther
lgtm https://codereview.chromium.org/794593002/diff/1/pkg/compiler/lib/src/resolution/members.dart File pkg/compiler/lib/src/resolution/members.dart (right): https://codereview.chromium.org/794593002/diff/1/pkg/compiler/lib/src/resolution/members.dart#newcode2794 pkg/compiler/lib/src/resolution/members.dart:2794: // the type literal from the receiver. 'receiver' ...
6 years ago (2014-12-11 13:12:07 UTC) #3
sigurdm
https://codereview.chromium.org/794593002/diff/1/pkg/compiler/lib/src/resolution/members.dart File pkg/compiler/lib/src/resolution/members.dart (right): https://codereview.chromium.org/794593002/diff/1/pkg/compiler/lib/src/resolution/members.dart#newcode2794 pkg/compiler/lib/src/resolution/members.dart:2794: // the type literal from the receiver. On 2014/12/11 ...
6 years ago (2014-12-11 13:31:55 UTC) #4
sigurdm
6 years ago (2014-12-11 13:36:34 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as 42286 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698