Issue 794493003: Re-enable regexp test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 794493003: Re-enable regexp test. (Closed)

Created:
6 years ago by Florian Schneider

Modified:
6 years ago

Reviewers:
zerny-google

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Re-enable regexp test. This test was skipped because of too long-running. It is now finishing faster (2s release-checked, 10s debug mode) R=zerny@google.com Committed: https://code.google.com/p/dart/source/detail?r=42426

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -3 lines)			Patch
	M	tests/corelib/corelib.status	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Total messages: 4 (1 generated)

Florian Schneider

Do you think it is fast enough to enable it? GetBlock is not on the ...

6 years ago (2014-12-15 10:50:18 UTC) #2

zerny-google

That should be fast enough. If not, the test should rather be marked slow on ...

6 years ago (2014-12-15 12:22:37 UTC) #3

Florian Schneider

6 years ago (2014-12-17 10:02:02 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as r42426 (presubmit successful).