Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 79353003: [polymer.dart] fix *Changed observers inheriting (Closed)

Created:
7 years, 1 month ago by Jennifer Messerly
Modified:
7 years, 1 month ago
CC:
reviews_dartlang.org, Alan Knight
Visibility:
Public.

Description

[polymer.dart] fix *Changed observers inheriting. R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=30561

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -40 lines) Patch
M pkg/pkg.status View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/polymer/lib/src/declaration.dart View 1 2 3 4 chunks +31 lines, -29 lines 0 comments Download
M pkg/polymer/lib/src/instance.dart View 2 chunks +10 lines, -2 lines 0 comments Download
M pkg/polymer/test/event_handlers_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/polymer/test/event_handlers_test.html View 1 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/polymer/test/events_test.dart View 1 2 2 chunks +28 lines, -0 lines 0 comments Download
M pkg/polymer/test/events_test.html View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download
A pkg/polymer/test/property_change_test.dart View 1 1 chunk +58 lines, -0 lines 0 comments Download
A + pkg/polymer/test/property_change_test.html View 1 chunk +4 lines, -6 lines 0 comments Download
M pkg/polymer/test/publish_attributes_test.dart View 1 2 2 chunks +13 lines, -1 line 0 comments Download
M pkg/polymer/test/publish_attributes_test.html View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jennifer Messerly
https://codereview.chromium.org/79353003/diff/1/pkg/polymer/lib/src/declaration.dart File pkg/polymer/lib/src/declaration.dart (left): https://codereview.chromium.org/79353003/diff/1/pkg/polymer/lib/src/declaration.dart#oldcode518 pkg/polymer/lib/src/declaration.dart:518: for (var getter in cls.declarations.values) { with .declarations, we ...
7 years, 1 month ago (2013-11-21 00:07:34 UTC) #1
Siggi Cherem (dart-lang)
I believe this will also fix if you have an event listener in the base ...
7 years, 1 month ago (2013-11-21 01:42:40 UTC) #2
Jennifer Messerly
good call. yes, the idea is to fix event listeners too :)
7 years, 1 month ago (2013-11-21 01:44:51 UTC) #3
Jennifer Messerly
7 years, 1 month ago (2013-11-22 03:04:36 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 manually as r30561 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698