Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 792853002: Revert "Revert "Disable the irregexp backend."" (Closed)

Created:
6 years ago by zerny-google
Modified:
6 years ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Revert "Revert "Disable the irregexp backend."" This reverts commit http://code.google.com/p/dart/source/detail?r=42240 Reason for revert: failures and timeouts on Dartium bots. TBR=fschneider@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=42246

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -3 lines) Patch
M runtime/lib/regexp.cc View 1 chunk +1 line, -1 line 0 comments Download
M tests/co19/co19-dart2dart.status View 2 chunks +9 lines, -0 lines 0 comments Download
M tests/co19/co19-runtime.status View 2 chunks +6 lines, -0 lines 0 comments Download
M tests/corelib/corelib.status View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
zerny-google
6 years ago (2014-12-10 15:37:59 UTC) #1
zerny-google
Committed patchset #1 (id:1) manually as 42246 (presubmit successful).
6 years ago (2014-12-10 15:38:19 UTC) #2
Florian Schneider
6 years ago (2014-12-11 10:28:41 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698