Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 791953007: Ensure that pub doesn't double-complete its captureErrors future. (Closed)

Created:
5 years, 11 months ago by nweiz
Modified:
5 years, 11 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Ensure that pub doesn't double-complete its captureErrors future. R=rnystrom@google.com BUG=21964 Committed: https://code.google.com/p/dart/source/detail?r=42886

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M sdk/lib/_internal/pub/lib/src/utils.dart View 2 chunks +5 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub_generated/lib/src/utils.dart View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
nweiz
5 years, 11 months ago (2015-01-14 20:19:40 UTC) #1
Bob Nystrom
When was this occurring?
5 years, 11 months ago (2015-01-14 20:53:09 UTC) #2
nweiz
On 2015/01/14 20:53:09, Bob Nystrom wrote: > When was this occurring? The only place I ...
5 years, 11 months ago (2015-01-14 20:56:21 UTC) #3
Bob Nystrom
lgtm
5 years, 11 months ago (2015-01-14 20:59:03 UTC) #4
nweiz
5 years, 11 months ago (2015-01-14 21:29:42 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 42886 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698