suggest fields rather than synthetic getters

suggest fields rather than synthetic getters
and return dynamic returnType rather than null

BUG=dartbug.com/21679
R=paulberry@google.com

Committed: https://code.google.com/p/dart/source/detail?r=42786

[danrubel, 2015-01-12 03:27:13]

danrubel@google.com changed reviewers:
+ paulberry@google.com

[Paul Berry, 2015-01-12 17:29:21]

lgtm if NO_RETURN_TYPE is refactored.

https://codereview.chromium.org/791553007/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart
(right):

https://codereview.chromium.org/791553007/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart:19:
final DartType NO_RETURN_TYPE = new _NoReturnType();
_LocalVisitor
(pkg/analysis_server/lib/src/services/completion/local_computer.dart) defines
NO_RETURN_TYPE as new TypeName(new SimpleIdentifier(new
StringToken(TokenType.IDENTIFIER, '', 0)), null).  We shouldn't have redundant
definitions.  I'd recommend removing the definition in local_computer.dart and
changing that file to refer to the definition here.

https://codereview.chromium.org/791553007/diff/1/pkg/analysis_server/tool/spe...
File pkg/analysis_server/tool/spec/spec_input.html (right):

https://codereview.chromium.org/791553007/diff/1/pkg/analysis_server/tool/spe...
pkg/analysis_server/tool/spec/spec_input.html:2009: The return type of the
getter, function or method
I think this sentence would be clearer with a comma after "method".

[danrubel, 2015-01-12 19:01:13]

https://codereview.chromium.org/791553007/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart
(right):

https://codereview.chromium.org/791553007/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart:19:
final DartType NO_RETURN_TYPE = new _NoReturnType();
On 2015/01/12 17:29:20, Paul Berry wrote:
> _LocalVisitor
> (pkg/analysis_server/lib/src/services/completion/local_computer.dart) defines
> NO_RETURN_TYPE as new TypeName(new SimpleIdentifier(new
> StringToken(TokenType.IDENTIFIER, '', 0)), null).  We shouldn't have redundant
> definitions.  I'd recommend removing the definition in local_computer.dart and
> changing that file to refer to the definition here.

That is definitely my long term intent, but these constants are two different
types so the refactoring is a bit more complex than a simple replacement. I'll
handle this in a separate CL.

[danrubel, 2015-01-12 19:02:53]

Committed patchset #2 (id:20001) manually as 42786 (presubmit successful).

[Paul Berry, 2015-01-12 19:02:56]

https://codereview.chromium.org/791553007/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart
(right):

https://codereview.chromium.org/791553007/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart:19:
final DartType NO_RETURN_TYPE = new _NoReturnType();
On 2015/01/12 19:01:13, danrubel wrote:
> On 2015/01/12 17:29:20, Paul Berry wrote:
> > _LocalVisitor
> > (pkg/analysis_server/lib/src/services/completion/local_computer.dart)
defines
> > NO_RETURN_TYPE as new TypeName(new SimpleIdentifier(new
> > StringToken(TokenType.IDENTIFIER, '', 0)), null).  We shouldn't have
redundant
> > definitions.  I'd recommend removing the definition in local_computer.dart
and
> > changing that file to refer to the definition here.
> 
> That is definitely my long term intent, but these constants are two different
> types so the refactoring is a bit more complex than a simple replacement. I'll
> handle this in a separate CL.

Ah, ok.  I understand now.  In that case, lgtm as is.