Issue 791543004: Revert "Isolates: allow sending of arbitrary objects in dart2js."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 791543004: Revert "Isolates: allow sending of arbitrary objects in dart2js." (Closed)

Created:
6 years ago by floitsch

Modified:
6 years ago

Reviewers:
Lasse Reichstein Nielsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Revert "Isolates: allow sending of arbitrary objects in dart2js." This reverts commit r42161. Revert "Update status file." This reverts commit r42163. Revert "Update test." This reverts commit r42165. Revert "Update status file." This reverts commit r42166. Committed: https://code.google.com/p/dart/source/detail?r=42206

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+566 lines, -949 lines)			Patch
M	pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart	View	3 chunks	+11 lines, -64 lines	0 comments	Download
M	sdk/lib/_internal/compiler/js_lib/collection_patch.dart	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	sdk/lib/_internal/compiler/js_lib/isolate_helper.dart	View	7 chunks	+441 lines, -34 lines	0 comments	Download
D	sdk/lib/_internal/compiler/js_lib/isolate_serialization.dart	View	1 chunk	+0 lines, -361 lines	0 comments	Download
M	sdk/lib/_internal/compiler/js_lib/js_helper.dart	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	sdk/lib/_internal/compiler/js_lib/native_helper.dart	View	1 chunk	+2 lines, -5 lines	0 comments	Download
M	sdk/lib/_internal/compiler/js_lib/shared/embedded_names.dart	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	tests/isolate/function_send_test.dart	View	1 chunk	+7 lines, -6 lines	0 comments	Download
M	tests/isolate/isolate.status	View	6 chunks	+10 lines, -13 lines	0 comments	Download
D	tests/isolate/message3_test.dart	View	1 chunk	+0 lines, -438 lines	0 comments	Download
M	tests/isolate/object_leak_test.dart	View	1 chunk	+14 lines, -12 lines	0 comments	Download
A	tests/isolate/serialization_test.dart	View	1 chunk	+78 lines, -0 lines	0 comments	Download
M	tests/language/language_dart2js.status	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

floitsch

Committed patchset #1 (id:1) manually as 42206 (presubmit successful).

6 years ago (2014-12-09 13:25:36 UTC) #3

Message was sent while issue was closed.

LGTM (well, not really *good*, but ok).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages