Issue 79143005: Followup on co19-roll to r667, marked co19/Language/12_Expressions/32_Type_Test_A02_t04 as failing …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 79143005: Followup on co19-roll to r667, marked co19/Language/12_Expressions/32_Type_Test_A02_t04 as failing … (Closed)

Created:
7 years, 1 month ago by kustermann

Modified:
7 years, 1 month ago

Reviewers:
ricow1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Followup on co19-roll to r667, marked co19/Language/12_Expressions/32_Type_Test_A02_t04 as failing in minified mode Committed: https://code.google.com/p/dart/source/detail?r=30513

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	dart/tests/co19/co19-dart2dart.status	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
	M	dart/tools/testing/dart/co19_test.dart	View		1 chunk	+1 line, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kustermann

Committed patchset #2 manually as r30513 (presubmit successful).

7 years, 1 month ago (2013-11-21 12:10:02 UTC) #2

ricow1

7 years, 1 month ago (2013-11-21 12:10:39 UTC) #3

Message was sent while issue was closed.

LGTM

https://codereview.chromium.org/79143005/diff/30001/dart/tools/testing/dart/c...
File dart/tools/testing/dart/co19_test.dart (right):

https://codereview.chromium.org/79143005/diff/30001/dart/tools/testing/dart/c...
dart/tools/testing/dart/co19_test.dart:39: const <String>['-mrelease', '-rvm',
'-cdart2dart', '--use-sdk', '--minified'],
long line

Expand Messages | Collapse Messages