Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1410)

Issue 790553002: Handle "fail_" style tests in reflective tests. (Closed)

Created:
6 years ago by Paul Berry
Modified:
6 years ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Handle "fail_" style tests in reflective tests. There is one corner case we don't handle--we don't catch the case where the test is expected to fail, but the failure comes from an asynchronous callback invoked via expectAsync(). Fortunately expectAsync() is rare enough that this doesn't cause a problem with any of our existing "fail_" style tests. R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=42180

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -1 line) Patch
M pkg/analyzer/test/reflective_tests.dart View 2 chunks +29 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Paul Berry
6 years ago (2014-12-08 19:45:36 UTC) #2
scheglov
LGTM Do you want to update also the second copy of reflective_tests.dart in the analysis_server ...
6 years ago (2014-12-08 19:48:25 UTC) #3
Paul Berry
On 2014/12/08 19:48:25, scheglov wrote: > LGTM > > Do you want to update also ...
6 years ago (2014-12-08 20:32:52 UTC) #4
Paul Berry
6 years ago (2014-12-08 20:33:33 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 42180 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698