Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 790363006: Upgrade unittest to be able to use isNotEmpty. (Closed)

Created:
6 years ago by scheglov
Modified:
6 years ago
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Upgrade unittest to be able to use isNotEmpty. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=42380

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M pkg/analysis_server/pubspec.yaml View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/analysis_server_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/domain_analysis_test.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/update_content_list_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/integration/analysis/update_content_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/socket_server_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
6 years ago (2014-12-15 21:24:47 UTC) #1
Brian Wilkerson
LGTM
6 years ago (2014-12-15 23:30:02 UTC) #2
scheglov
6 years ago (2014-12-16 04:07:45 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 42380 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698