Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 79023010: Add demangle utility to Dartium's dart:html. Demangle typedef names in UserVisibleName. (Closed)

Created:
7 years, 1 month ago by rmacnak
Modified:
7 years ago
Reviewers:
vsm, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Add demangle utility to Dartium's dart:html. Demangle typedef names in UserVisibleName. BUG=http://dartbug.com/14892 R=asiva@google.com, vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=30636

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M runtime/lib/mirrors.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/object.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M tests/lib/mirrors/private_symbol_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/src/native_DOMImplementation.dart View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
rmacnak
Goes with https://codereview.chromium.org/81213004/
7 years, 1 month ago (2013-11-21 22:05:19 UTC) #1
rmacnak
Woops, meant asiva
7 years, 1 month ago (2013-11-21 22:24:12 UTC) #2
rmacnak
7 years, 1 month ago (2013-11-21 22:24:29 UTC) #3
vsm
lgtm
7 years, 1 month ago (2013-11-21 22:26:26 UTC) #4
rmacnak
Small tweak to mirrors to keep private symbol test passing.
7 years, 1 month ago (2013-11-22 18:15:35 UTC) #5
siva
lgtm
7 years ago (2013-11-25 18:03:20 UTC) #6
rmacnak
7 years ago (2013-11-25 18:31:29 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 manually as r30636 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698