Issue 790143002: Fix dead phis elimination.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 790143002: Fix dead phis elimination. (Closed)

Created:
6 years ago by Florian Schneider

Modified:
6 years ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix dead phis elimination. When initially marking live phis, only mark those with real (i.e. non-phi) uses as live so that cycles are properly eliminated. Add a pass after allocation sinking since it may create additional dead phis. R=vegorov@google.com Committed: https://code.google.com/p/dart/source/detail?r=42245

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -1 line)			Patch
	M	runtime/vm/compiler.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	runtime/vm/flow_graph_optimizer.cc	View		2 chunks	+14 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Florian Schneider

6 years ago (2014-12-10 14:28:44 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as r42245 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages