Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 790063002: Instrument communications (Closed)

Created:
6 years ago by Brian Wilkerson
Modified:
6 years ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -6 lines) Patch
M pkg/analysis_server/lib/http_server.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/channel/byte_stream_channel.dart View 6 chunks +10 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/channel/channel.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/channel/web_socket_channel.dart View 5 chunks +10 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/stdio_server.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/channel/byte_stream_channel_test.dart View 2 chunks +5 lines, -1 line 0 comments Download
M pkg/analysis_server/test/channel/web_socket_channel_test.dart View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Brian Wilkerson
Do we want any indication of whether the data was incoming or outgoing?
6 years ago (2014-12-10 05:07:45 UTC) #2
scheglov
LGTM Yes, I think we want indicators, like => and <=, to simplify reading of ...
6 years ago (2014-12-10 15:09:39 UTC) #3
danrubel
On 2014/12/10 15:09:39, scheglov wrote: > LGTM > > Yes, I think we want indicators, ...
6 years ago (2014-12-10 15:20:19 UTC) #4
lukechurch
lgtm. It would like send and recieve markers, ideally that are improbable so we can ...
6 years ago (2014-12-10 15:52:34 UTC) #5
Brian Wilkerson
6 years ago (2014-12-10 16:48:16 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 42250 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698