Complete and clean up breakpoint support in all 3 debuggers embedded in MIPS,

Complete and clean up breakpoint support in all 3 debuggers embedded in MIPS,
ARM, and ARM64 simulators.
Implement the same debugging commands in all 3 simulators: stop_sim_at flag, bt,
p icount, break, del, unstop, etc...

R=zra@google.com

Committed: https://code.google.com/p/dart/source/detail?r=42216

[regis, 2014-12-09 18:27:00]

regis@google.com changed reviewers:
+ zra@google.com

[zra, 2014-12-09 18:50:41]

lgtm with suggestion.

Thanks for doing this =)

https://codereview.chromium.org/789903002/diff/1/runtime/vm/simulator_arm.cc
File runtime/vm/simulator_arm.cc (right):

https://codereview.chromium.org/789903002/diff/1/runtime/vm/simulator_arm.cc#...
runtime/vm/simulator_arm.cc:550: Disassembler::Disassemble(start, end);
If GetValue returns false, start and end will both be 0.  If that happens, maybe
skip this call and give a warning.

https://codereview.chromium.org/789903002/diff/1/runtime/vm/simulator_arm64.cc
File runtime/vm/simulator_arm64.cc (right):

https://codereview.chromium.org/789903002/diff/1/runtime/vm/simulator_arm64.c...
runtime/vm/simulator_arm64.cc:601: Disassembler::Disassemble(start, end);
Same comment.

https://codereview.chromium.org/789903002/diff/1/runtime/vm/simulator_mips.cc
File runtime/vm/simulator_mips.cc (right):

https://codereview.chromium.org/789903002/diff/1/runtime/vm/simulator_mips.cc...
runtime/vm/simulator_mips.cc:560: Disassembler::Disassemble(start, end);
Same comment.

[regis, 2014-12-09 19:23:25]

PTAL

Thanks!

https://codereview.chromium.org/789903002/diff/1/runtime/vm/simulator_arm.cc
File runtime/vm/simulator_arm.cc (right):

https://codereview.chromium.org/789903002/diff/1/runtime/vm/simulator_arm.cc#...
runtime/vm/simulator_arm.cc:550: Disassembler::Disassemble(start, end);
On 2014/12/09 18:50:41, zra wrote:
> If GetValue returns false, start and end will both be 0.  If that happens,
maybe
> skip this call and give a warning.

Done.

https://codereview.chromium.org/789903002/diff/1/runtime/vm/simulator_arm64.cc
File runtime/vm/simulator_arm64.cc (right):

https://codereview.chromium.org/789903002/diff/1/runtime/vm/simulator_arm64.c...
runtime/vm/simulator_arm64.cc:601: Disassembler::Disassemble(start, end);
On 2014/12/09 18:50:41, zra wrote:
> Same comment.

Done.

https://codereview.chromium.org/789903002/diff/1/runtime/vm/simulator_mips.cc
File runtime/vm/simulator_mips.cc (right):

https://codereview.chromium.org/789903002/diff/1/runtime/vm/simulator_mips.cc...
runtime/vm/simulator_mips.cc:560: Disassembler::Disassemble(start, end);
On 2014/12/09 18:50:41, zra wrote:
> Same comment.

Done.

[zra, 2014-12-09 19:26:06]

lgtm

[regis, 2014-12-09 19:26:42]

Committed patchset #3 (id:40001) manually as r42216.