Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1431)

Issue 789643006: Introduce is_debuggable state bit on function objects (Closed)

Created:
5 years, 11 months ago by hausner
Modified:
5 years, 11 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Introduce is_debuggable state bit on function objects Simplify debugger logic. Any function can be marked as non-debuggable when is is created. The debugger no longer needs a heuristic which functions are debuggable. Mostly used for synthetic, generated functions that have no source code, e.g. async code, implicit getters and setters, implicit constructors, forwarding constructors, dispatcher functions. Committed: https://code.google.com/p/dart/source/detail?r=42570

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -30 lines) Patch
M runtime/vm/class_finalizer.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/vm/compiler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/debugger.cc View 1 10 chunks +19 lines, -24 lines 0 comments Download
M runtime/vm/megamorphic_cache_table.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/object.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/object.cc View 4 chunks +3 lines, -1 line 0 comments Download
M runtime/vm/parser.cc View 1 2 13 chunks +24 lines, -5 lines 0 comments Download
M runtime/vm/regexp.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/resolver.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
hausner
5 years, 11 months ago (2014-12-29 20:27:44 UTC) #2
siva
The CL in general looks good, I have two questions - native functions should also ...
5 years, 11 months ago (2014-12-29 22:11:58 UTC) #3
hausner
Good point about native functions. I changed the parser to mark them as non-debuggable. Visibility ...
5 years, 11 months ago (2014-12-29 22:26:59 UTC) #4
hausner
5 years, 11 months ago (2014-12-29 22:31:24 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as r42570 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698