Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 789543002: Ignore ButtonType when computing an extracted method return type. (Closed)

Created:
6 years ago by scheglov
Modified:
6 years ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Ignore ButtonType when computing an extracted method return type. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=42201

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -9 lines) Patch
M pkg/analysis_server/lib/src/services/refactoring/extract_method.dart View 1 chunk +16 lines, -9 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/extract_method_test.dart View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
6 years ago (2014-12-08 22:31:27 UTC) #1
Brian Wilkerson
LGTM
6 years ago (2014-12-09 00:04:43 UTC) #2
scheglov
6 years ago (2014-12-09 02:20:02 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 42201 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698