Issue 789503002: Update test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 789503002: Update test. (Closed)

Created:
6 years ago by floitsch

Modified:
6 years ago

Reviewers:
Lasse Reichstein Nielsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Update test. Now that dart2js can send arbitrary objects, this test went through a different route, where it encountered non-zero timers. These are not supported for jsshell. I rewrote the test not to use a timer, but wait for a reply from the spawned isolate instead. Committed: https://code.google.com/p/dart/source/detail?r=42165

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -14 lines)			Patch
	M	tests/isolate/object_leak_test.dart	View		1 chunk	+12 lines, -14 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

floitsch

Committed patchset #1 (id:1) manually as 42165 (presubmit successful).

6 years ago (2014-12-08 14:14:05 UTC) #3

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages