Support type argument substitution on unnamed mixin applications.

Support type argument substitution on unnamed mixin applications.

R=ahe@google.com, johnniwinther@google.com

Committed: https://code.google.com/p/dart/source/detail?r=31319

[ahe, 2013-11-21 15:15:33]

https://codereview.chromium.org/78873007/diff/20001/sdk/lib/_internal/lib/js_...
File sdk/lib/_internal/lib/js_mirrors.dart (right):

https://codereview.chromium.org/78873007/diff/20001/sdk/lib/_internal/lib/js_...
sdk/lib/_internal/lib/js_mirrors.dart:481: {ClassMirror context}) {
I'm not sure about this. Let's talk face to face tomorrow.

[Johnni Winther, 2013-11-25 07:19:20]

lgtm

https://codereview.chromium.org/78873007/diff/20001/sdk/lib/_internal/compile...
File
sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart
(right):

https://codereview.chromium.org/78873007/diff/20001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart:65:
*/""}mangledGlobalNames[previousProperty] = property.substring(1);
Indent to align `mangledGlobalNames...` under `firstChar`.

https://codereview.chromium.org/78873007/diff/20001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart:66:
if (element == 1) descriptor[previousProperty].$reflectableField = 1;
Indent to align with `if (element)...` below.

https://codereview.chromium.org/78873007/diff/20001/sdk/lib/_internal/lib/js_...
File sdk/lib/_internal/lib/js_mirrors.dart (right):

https://codereview.chromium.org/78873007/diff/20001/sdk/lib/_internal/lib/js_...
sdk/lib/_internal/lib/js_mirrors.dart:490: ClassMirror context) {
Either both or none of [reflectClassByName] and [reflectClassByMangledName]
should use have [context] as a named argument.

https://codereview.chromium.org/78873007/diff/20001/sdk/lib/_internal/lib/js_...
sdk/lib/_internal/lib/js_mirrors.dart:644: ClassMirror _context;
Make this final.

https://codereview.chromium.org/78873007/diff/20001/sdk/lib/_internal/lib/js_...
sdk/lib/_internal/lib/js_mirrors.dart:648: JsMixinApplication(String
mangledName, this._context)
Assert that _context is not Null.

https://codereview.chromium.org/78873007/diff/20001/sdk/lib/_internal/lib/js_...
sdk/lib/_internal/lib/js_mirrors.dart:730: ClassMirror get originalDeclaration
=> this;
These can't be true: Either it is the original declaration in which case it
returns this in [originalDeclaration] or is not the original declaration in
which case it returns another mirror in [originalDeclaration].

https://codereview.chromium.org/78873007/diff/20001/tests/lib/mirrors/equalit...
File tests/lib/mirrors/equality_test.dart (right):

https://codereview.chromium.org/78873007/diff/20001/tests/lib/mirrors/equalit...
tests/lib/mirrors/equality_test.dart:128: :
(reflectClass(BadEqualityHash).declarations[#==] as MethodMirror).parameters[0],
Long line.

https://codereview.chromium.org/78873007/diff/20001/tests/lib/mirrors/equalit...
tests/lib/mirrors/equality_test.dart:130: : (reflect(new
BadEqualityHash()).type.declarations[#==] as MethodMirror).parameters[0]},
Long line.

[zarah, 2013-12-19 10:53:33]

PTAL

https://codereview.chromium.org/78873007/diff/20001/sdk/lib/_internal/compile...
File
sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart
(right):

https://codereview.chromium.org/78873007/diff/20001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart:65:
*/""}mangledGlobalNames[previousProperty] = property.substring(1);
On 2013/11/25 07:19:20, Johnni Winther wrote:
> Indent to align `mangledGlobalNames...` under `firstChar`.

Done.

https://codereview.chromium.org/78873007/diff/20001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart:66:
if (element == 1) descriptor[previousProperty].$reflectableField = 1;
On 2013/11/25 07:19:20, Johnni Winther wrote:
> Indent to align with `if (element)...` below.

Done.

https://codereview.chromium.org/78873007/diff/20001/sdk/lib/_internal/lib/js_...
File sdk/lib/_internal/lib/js_mirrors.dart (right):

https://codereview.chromium.org/78873007/diff/20001/sdk/lib/_internal/lib/js_...
sdk/lib/_internal/lib/js_mirrors.dart:490: ClassMirror context) {
On 2013/11/25 07:19:20, Johnni Winther wrote:
> Either both or none of [reflectClassByName] and [reflectClassByMangledName]
> should use have [context] as a named argument.

Done.

https://codereview.chromium.org/78873007/diff/20001/sdk/lib/_internal/lib/js_...
sdk/lib/_internal/lib/js_mirrors.dart:644: ClassMirror _context;
On 2013/11/25 07:19:20, Johnni Winther wrote:
> Make this final.

Done.

https://codereview.chromium.org/78873007/diff/20001/sdk/lib/_internal/lib/js_...
sdk/lib/_internal/lib/js_mirrors.dart:648: JsMixinApplication(String
mangledName, this._context)
On 2013/11/25 07:19:20, Johnni Winther wrote:
> Assert that _context is not Null.

Done.

https://codereview.chromium.org/78873007/diff/20001/sdk/lib/_internal/lib/js_...
sdk/lib/_internal/lib/js_mirrors.dart:730: ClassMirror get originalDeclaration
=> this;
On 2013/11/25 07:19:20, Johnni Winther wrote:
> These can't be true: Either it is the original declaration in which case it
> returns this in [originalDeclaration] or is not the original declaration in
> which case it returns another mirror in [originalDeclaration].

Done.

https://codereview.chromium.org/78873007/diff/20001/tests/lib/mirrors/equalit...
File tests/lib/mirrors/equality_test.dart (right):

https://codereview.chromium.org/78873007/diff/20001/tests/lib/mirrors/equalit...
tests/lib/mirrors/equality_test.dart:128: :
(reflectClass(BadEqualityHash).declarations[#==] as MethodMirror).parameters[0],
On 2013/11/25 07:19:20, Johnni Winther wrote:
> Long line.

Done.

https://codereview.chromium.org/78873007/diff/20001/tests/lib/mirrors/equalit...
tests/lib/mirrors/equality_test.dart:130: : (reflect(new
BadEqualityHash()).type.declarations[#==] as MethodMirror).parameters[0]},
On 2013/11/25 07:19:20, Johnni Winther wrote:
> Long line.

Done.

[ahe, 2013-12-19 11:57:06]

LGTM!

https://codereview.chromium.org/78873007/diff/90001/sdk/lib/_internal/compile...
File
sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart
(right):

https://codereview.chromium.org/78873007/diff/90001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart:187:
*/""}          mangledGlobalNames[previousProperty] = property.substring(1);
Restore the other version, Johnni prefers it that way.

https://codereview.chromium.org/78873007/diff/90001/sdk/lib/_internal/lib/js_...
File sdk/lib/_internal/lib/js_mirrors.dart (right):

https://codereview.chromium.org/78873007/diff/90001/sdk/lib/_internal/lib/js_...
sdk/lib/_internal/lib/js_mirrors.dart:156: Symbol get simpleName;
Remove all public methods. They are redundant.

https://codereview.chromium.org/78873007/diff/90001/sdk/lib/_internal/lib/js_...
sdk/lib/_internal/lib/js_mirrors.dart:586:
reflectClassByMangledName(mangledName.substring(0,
typeArgIndex)).originalDeclaration,
Long line.

[zarah, 2013-12-20 07:32:39]

Committed patchset #3 manually as r31319 (presubmit successful).

[zarah, 2013-12-20 13:17:21]

https://codereview.chromium.org/78873007/diff/90001/sdk/lib/_internal/compile...
File
sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart
(right):

https://codereview.chromium.org/78873007/diff/90001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart:187:
*/""}          mangledGlobalNames[previousProperty] = property.substring(1);
On 2013/12/19 11:57:06, ahe wrote:
> Restore the other version, Johnni prefers it that way.

Done.

https://codereview.chromium.org/78873007/diff/90001/sdk/lib/_internal/lib/js_...
File sdk/lib/_internal/lib/js_mirrors.dart (right):

https://codereview.chromium.org/78873007/diff/90001/sdk/lib/_internal/lib/js_...
sdk/lib/_internal/lib/js_mirrors.dart:156: Symbol get simpleName;
On 2013/12/19 11:57:06, ahe wrote:
> Remove all public methods. They are redundant.

Done.

https://codereview.chromium.org/78873007/diff/90001/sdk/lib/_internal/lib/js_...
sdk/lib/_internal/lib/js_mirrors.dart:586:
reflectClassByMangledName(mangledName.substring(0,
typeArgIndex)).originalDeclaration,
On 2013/12/19 11:57:06, ahe wrote:
> Long line.

Done.