Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 788403005: Mark test with issue number in co19 status file (Closed)

Created:
6 years ago by sigurdm
Modified:
6 years ago
Reviewers:
karlklose, floitsch
CC:
reviews_dartlang.org, floitsch
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Mark test with issue number in co19 status file I think that this bug is the right one, though it seems there is disagreement as to whether you can trust identity of errors/stack traces after rethrow. See: https://codereview.chromium.org/78343002 (Ivans comment) and dartbug.com/18394 that suggests the test is wrong. R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=42423

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tests/co19/co19-dart2js.status View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
sigurdm
6 years ago (2014-12-16 15:13:57 UTC) #2
sigurdm
6 years ago (2014-12-16 15:14:14 UTC) #3
floitsch
LGTM.
6 years ago (2014-12-16 19:06:37 UTC) #5
sigurdm
6 years ago (2014-12-17 08:32:58 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 42423 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698