Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 788043004: Add MacOS content_shell download to homebrew formula update app. (Closed)

Created:
6 years ago by Bill Hesse
Modified:
6 years ago
Reviewers:
ricow1, Nicolas Garnier
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Add MacOS content_shell download to homebrew formula update app. BUG=dartbug.com/21717 R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=42251

Patch Set 1 #

Total comments: 1

Patch Set 2 : Move block to fix unknown error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -3 lines) Patch
M tools/apps/update_homebrew/bin/update_homebrew.dart View 1 3 chunks +22 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Bill Hesse
6 years ago (2014-12-10 10:30:24 UTC) #2
ricow1
lgtm
6 years ago (2014-12-10 10:33:11 UTC) #3
Nicolas Garnier
https://codereview.chromium.org/788043004/diff/1/tools/apps/update_homebrew/bin/update_homebrew.dart File tools/apps/update_homebrew/bin/update_homebrew.dart (right): https://codereview.chromium.org/788043004/diff/1/tools/apps/update_homebrew/bin/update_homebrew.dart#newcode122 tools/apps/update_homebrew/bin/update_homebrew.dart:122: resource 'content_shell' do I think this should be put ...
6 years ago (2014-12-10 10:41:15 UTC) #4
Bill Hesse
On 2014/12/10 10:41:15, Nicolas Garnier wrote: > https://codereview.chromium.org/788043004/diff/1/tools/apps/update_homebrew/bin/update_homebrew.dart > File tools/apps/update_homebrew/bin/update_homebrew.dart (right): > > https://codereview.chromium.org/788043004/diff/1/tools/apps/update_homebrew/bin/update_homebrew.dart#newcode122 ...
6 years ago (2014-12-10 14:22:36 UTC) #5
Bill Hesse
6 years ago (2014-12-10 17:04:40 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 42251 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698