Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Issue 787863003: Make completion tests handle exceptions during getSuggestions(). (Closed)

Created:
6 years ago by Paul Berry
Modified:
6 years ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make completion tests handle exceptions during getSuggestions(). Previously, if an exception occurred during getSuggestions(), or the future returned by it completed with an error, the completion test would exit without calling tearDown(). R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=42217

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -21 lines) Patch
M pkg/analysis_server/test/completion_test_support.dart View 1 chunk +20 lines, -21 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
6 years ago (2014-12-09 16:59:31 UTC) #2
Brian Wilkerson
LGTM
6 years ago (2014-12-09 19:31:09 UTC) #3
Paul Berry
6 years ago (2014-12-09 19:34:52 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 42217 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698