Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 787763004: Hooks for instrumentation (Closed)

Created:
6 years ago by Brian Wilkerson
Modified:
6 years ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -23 lines) Patch
M pkg/analysis_server/lib/driver.dart View 4 chunks +37 lines, -10 lines 0 comments Download
M pkg/analysis_server/lib/src/analysis_server.dart View 3 chunks +7 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/socket_server.dart View 4 chunks +5 lines, -1 line 0 comments Download
M pkg/analysis_server/test/analysis_abstract.dart View 2 chunks +3 lines, -1 line 0 comments Download
M pkg/analysis_server/test/analysis_server_test.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/domain_analysis_test.dart View 3 chunks +5 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/domain_completion_test.dart View 2 chunks +5 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/domain_execution_test.dart View 2 chunks +3 lines, -1 line 0 comments Download
M pkg/analysis_server/test/domain_server_test.dart View 2 chunks +3 lines, -1 line 0 comments Download
M pkg/analysis_server/test/socket_server_test.dart View 5 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Brian Wilkerson
This makes it possible for an instrumentation server to be set in the main method ...
6 years ago (2014-12-09 19:51:16 UTC) #2
scheglov
LGTM
6 years ago (2014-12-09 19:54:05 UTC) #3
Brian Wilkerson
Committed patchset #1 (id:1) manually as 42218 (presubmit successful).
6 years ago (2014-12-09 20:15:04 UTC) #4
danrubel
6 years ago (2014-12-10 15:23:50 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698