Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 787753005: Fix crash in typechecker (Closed)

Created:
6 years ago by Johnni Winther
Modified:
6 years ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix crash in typechecker BUG=http://dartbug.com/21793 R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=42236

Patch Set 1 #

Patch Set 2 : Add test. #

Total comments: 2

Patch Set 3 : Update cf. comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -18 lines) Patch
M pkg/compiler/lib/src/resolution/members.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/typechecker.dart View 2 chunks +5 lines, -1 line 0 comments Download
A + tests/language/regress_21793_test.dart View 1 2 1 chunk +6 lines, -15 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Johnni Winther
6 years ago (2014-12-09 13:39:15 UTC) #2
floitsch
LGTM. https://codereview.chromium.org/787753005/diff/20001/tests/language/regress_21793_test.dart File tests/language/regress_21793_test.dart (right): https://codereview.chromium.org/787753005/diff/20001/tests/language/regress_21793_test.dart#newcode17 tests/language/regress_21793_test.dart:17: test(); /// 01: continued Nit: I prefer to ...
6 years ago (2014-12-09 14:00:15 UTC) #3
Johnni Winther
Committed patchset #3 (id:40001) manually as 42236 (presubmit successful).
6 years ago (2014-12-10 08:30:02 UTC) #4
Johnni Winther
6 years ago (2014-12-10 08:37:19 UTC) #5
Message was sent while issue was closed.
https://codereview.chromium.org/787753005/diff/20001/tests/language/regress_2...
File tests/language/regress_21793_test.dart (right):

https://codereview.chromium.org/787753005/diff/20001/tests/language/regress_2...
tests/language/regress_21793_test.dart:17: test();  /// 01: continued
On 2014/12/09 14:00:15, floitsch wrote:
> Nit:
> I prefer to be more minimalistic in what we remove.
> If there was a typo in the "print" line, that it might not test the right
thing.
> 
> /*   /// 01: static type warning, runtime error
> class A { call(x) => x; }
> */   /// 01: continued
> 
> main() {
>   print(new A()(499));
> }

Done.

Powered by Google App Engine
This is Rietveld 408576698